-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix declaration-block-no-redundant-longhand-properties
autofix for border-width
shorthand
#6956
Conversation
…`border-width` shorthand
🦋 Changeset detectedLatest commit: b900c7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fixed: 'a { border-width: 0px 1px 2px 3px; }', | ||
description: 'explicit border-width test', | ||
message: messages.expected('border-width'), | ||
}, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example for margin
or border-width
or padding
for top | left/right | bottom
.
If if it's not supported yet add skip: true,
.
i.e. no need to do it in the same PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, a bit confused -- what do you mean by top | left/right | bottom
? Do you mean when all four are specified, or when some of the values are inferred/collapsed? The latter isn't covered by this rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latter isn't covered by this rule.
That's why I was proposing to add skip: true
for now.
It could be an enhancement; it's expected by users.
cf #6947
Can you add a test for stylelint/lib/reference/properties.js Lines 144 to 147 in b900c7b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM! 👍🏼
…`border-radius` shorthand (#6958) Ref: #6956 (comment)
Closes #6947.
Sorry that I missed this! Happy to quickly cut a new release if we'd like.